feat: add Safari support and refactor browser detection#430
Open
alcayaga wants to merge 1 commit intokheina-com:mainfrom
Open
feat: add Safari support and refactor browser detection#430alcayaga wants to merge 1 commit intokheina-com:mainfrom
alcayaga wants to merge 1 commit intokheina-com:mainfrom
Conversation
- Added `make safari` target to makefile for Safari-compatible manifest generation. - Refactored `Browser` constant in `src/constants.ts` to detect Safari. - Updated documentation in `readme.md` with Safari installation steps.
alcayaga
requested review from
jaredcat,
kheina and
rougetimelord
as code owners
rougetimelord
requested changes
Mar 3, 2026
| runtime: browser.runtime, | ||
| storage: browser.storage, | ||
| action: browser.browserAction, | ||
| action: browser.action || chrome.action, |
Collaborator
There was a problem hiding this comment.
I'm not sure if you need to include ||chrome.action here?
rougetimelord
approved these changes
Mar 3, 2026
Collaborator
rougetimelord
left a comment
rougetimelord
left a comment
There was a problem hiding this comment.
Extremely minor question, otherwise LGTM
Collaborator
|
Also FYI I don't have code ownership over the .gitignore, if you want the PR to merge faster you can remove the change to it or I can try to reach out to Kheina lmk |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the first step for Safari support as requested in #197.
make safaritarget to makefile for Safari-compatible manifest generation.Browserconstant insrc/constants.tsto detect Safari.readme.mdwith Safari installation steps.How to build for Safari
Read instructions in
readme.md, needs a Mac in order to use Xcode commands to create the app.What this PR doesn't cover?
Creation of Xcode .app and App Store distribution, they can be discussed once this PR is merged.