hw1#25
Open
Alexanderpublic wants to merge 5 commits into
Open
Conversation
Я попытался добить до mutable sequence, но не понял что делать в ее магических методах.
nmatkheev
reviewed
Mar 30, 2020
| " return x\n", | ||
| " \n", | ||
| " def append(self,data):\n", | ||
| " if (('len' in dir(data)) or ('__len__' in dir(data))):\n", |
Collaborator
There was a problem hiding this comment.
Можно было бы сделать проверку isinstance(data, collections.abc.Sized)
| " self.capacity+=1\n", | ||
| " \n", | ||
| " def insert(self, index, item):\n", | ||
| " if index!=0:\n", |
Collaborator
There was a problem hiding this comment.
Если индекс отрицательный?
| " \n", | ||
| " def __iter__(self):\n", | ||
| " for i in range(len(self)):\n", | ||
| " yield self.arraylist[i]\n", |
Collaborator
There was a problem hiding this comment.
Сделай через свой итератор
| " return False\n", | ||
| " \n", | ||
| " def __getitem__(self,index):\n", | ||
| " return self.arraylist[index]\n", |
Collaborator
There was a problem hiding this comment.
Поработай явным образом с slice-индексом.
| " def __setitem__(self, index, value):\n", | ||
| " t = self.arraylist[:index]\n", | ||
| " v = array(self.typecode,[value])\n", | ||
| " t = t + v + self.arraylist[index + 1:]\n", |
Collaborator
There was a problem hiding this comment.
Если индекс равен >= текущей длины?
Collaborator
There was a problem hiding this comment.
И что будет при отрицательном
| " \n", | ||
| " def __reversed__(self):\n", | ||
| " for i in range(len(self)-1,-1,-1):\n", | ||
| " yield self.arraylist[i]\n", |
| " self.capacity += 1\n", | ||
| " \n", | ||
| " def extend(self, item):\n", | ||
| " self.arraylist=array(self.typecode,self.arraylist[:]+array(self.typecode,[item]))\n", |
Collaborator
There was a problem hiding this comment.
extend обычно для добавления контейнеров используется
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Новая версия, постарался полностью сделать все найденные методы