Open
Conversation
…h multi-threaded environments
… error. Upgraded mocha and tests to MiniTest
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since I'm running geckoboard-push updates in sidekiq (which uses threads), I needed geckoboard-push to be thread-safe, which it obviously wasn't before (it was storing the api_key in a class variable). In my app, each Geckoboard push uses a different API key (the app user's key, not mine), so there would be a potential race condition.
This was a simple change. I basically just changed api_key and api_version to be instance variables, and updates tests accordingly.