Using security app to obtain API key#19
Open
krystianpiecko wants to merge 11 commits intokiddos:masterfrom
Open
Using security app to obtain API key#19krystianpiecko wants to merge 11 commits intokiddos:masterfrom
krystianpiecko wants to merge 11 commits intokiddos:masterfrom
Conversation
update version check
Owner
|
I like your idea, but this would break the Command that uses the stream function |
added 9 commits
September 2, 2025 20:13
Refactored the get_api_key function to be asynchronous (get_api_key_async) using vim.loop.spawn. This prevents blocking during streaming operations. - Updated gemini_generate_content and gemini_generate_content_stream to use the new asynchronous function. - Adjusted the test suite in tests/gemini/api_spec.lua to handle the asynchronous nature of the API calls, ensuring tests pass.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I wasn't comfortable pulling the API key directly from the environment variables. So, I've expanded the functionality to allow registering the API key in the macOS keychain. Planetery ran the tests successfully with this setup.
I'm sharing this with you as a heads-up and something to consider.