Remove rendering if priority label is empty.#136
Merged
Conversation
NiklasRentzCAU
approved these changes
Jun 13, 2025
Member
NiklasRentzCAU
left a comment
NiklasRentzCAU
left a comment
There was a problem hiding this comment.
As I said in KLighD, it might be dangerous to remove this property. Can you tell me what happens if the label manager is changed to show a label again after it has been removed here? If that does not break anything, this is good!
Member
Author
This does not seem to be an issue: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If no priority is available delete the rendering. This fixes the issue of the empty rendering being displayed for on edge labels.
See kieler/KLighD#231