Skip to content

[codex] Fix face bounding box return type#35

Open
thehanslevi wants to merge 1 commit into
kijai:mainfrom
thehanslevi:codex/fix-face-bbox-return-type
Open

[codex] Fix face bounding box return type#35
thehanslevi wants to merge 1 commit into
kijai:mainfrom
thehanslevi:codex/fix-face-bbox-return-type

Conversation

@thehanslevi

Copy link
Copy Markdown

Summary

  • correct the face_bboxes return type from BBOX, to BBOX
  • keep both bounding-box outputs on the same ComfyUI custom type

The comma was part of the type string rather than Python tuple syntax, so the fifth output advertised a different type from the adjacent bboxes output.

Closes #34.

Validation

  • python3 -m compileall -q .
  • AST assertion that RETURN_TYPES and RETURN_NAMES both contain five entries and the final two types are BBOX
  • git diff --check

The repository does not include a test suite, so no end-to-end ComfyUI workflow test was available.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Typo: "BBOX," -> "BBOX",

1 participant