Skip to content

Added DarkMode/LightMode#29

Open
ashish5433 wants to merge 5 commits intokillerkc12:masterfrom
ashish5433:master
Open

Added DarkMode/LightMode#29
ashish5433 wants to merge 5 commits intokillerkc12:masterfrom
ashish5433:master

Conversation

@ashish5433
Copy link

I have added Darkmode/Lightmode Button and I am attaching the some screenshots for your reference please review my PR and do let me know if any changes required.

Thanks.
Screenshot (504)
Screenshot (505)

@killerkc12
Copy link
Owner

Ok. I’ll review later and will let you know

Copy link
Owner

@killerkc12 killerkc12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ashish5433

  1. For dark and Light mode, used package which is ok. But if you see output is not so good.
  2. Right now not required to have the dark/light mode on the login page.
  3. Can you do it only on the main page? Please make sure to use centric CSS like you can declare color at first and then you can use it.

@ashish5433
Copy link
Author

Hii @killerkc12 can you please explain more the step 3rd

@killerkc12
Copy link
Owner

@ashish5433 For now just create new stylish button for dark light theme in the navbar.
For their implementation I will create new issue.

@ashish5433
Copy link
Author

Ok sure

@vercel
Copy link

vercel bot commented Oct 13, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
taskboard ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 15, 2023 1:13pm

@ashish5433
Copy link
Author

Hii @killerkc12 I have updated the button for light/dark mode please review it and do let me know if any changes required.
Screenshot (506)
Screenshot (507)

Copy link
Owner

@killerkc12 killerkc12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ashish5433 You've added a nice button. But this could give the problem in viewing the task for the last tasklist.
Could You please add a button in the Navbar? And if possible can convert the button into a switchable.
e.g.
image

@ashish5433
Copy link
Author

Yeah sure will do it in hour...

@ashish5433
Copy link
Author

Hii I have updated the toggler please review it .
Screenshot (508)
Screenshot (509)

@killerkc12
Copy link
Owner

killerkc12 commented Oct 15, 2023

@ashish5433 Could you please make the icon smaller and move it to the left side of the profile icon?
Please resolve the conflicts.

@ashish5433
Copy link
Author

Hii I have changed the toggler allignment and smaller its size .
image
image

@killerkc12
Copy link
Owner

@ashish5433 looking good now.
I’m ready to merge but in the file changes, there are files changes which don’t require like packaging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants