chore: HexRealRootsMathlib scaffolding review and phase bumps#8754
Merged
Conversation
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01NUB5EStJpJ8CPqMkNw7Qjz
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR records the Phase 2 skeptical review of HexRealRootsMathlib and advances its phase counter to 3. A reviewer agent distinct from the authors read every file of the library against SPEC/Libraries/hex-real-roots-mathlib.md and confirmed every SPEC theorem is present with faithful, non-vacuous content across SturmChainDefs, SturmTheorem, ChainCorrespond, Separation, Isolations, Drivers, and SimpleRealRoot, with the single SPEC-sanctioned sorry (isolateDescartes?_isSome, deferred behind the Obreshkoff two-circle theorem) verified to be the only one. The review confirms the documented hypothesis adjustments are sound: p ≠ 0 shapes where SquareFreeRat alone is vacuous, the primitivePart head on the chain correspondence, and the 1 ≤ degree hypotheses retained on the count correspondences. #print axioms is clean of sorryAx on isolate?_isSome, sepPrec_separates', Sturm.sturm_half_open, and overlaps_iff_same_root, each depending only on propext, Classical.choice, and Quot.sound.
The Phase 3 conformance module already exists at conformance/HexRealRootsMathlib/Conformance.lean and is reached by the HexConformance globs; its oracle is the proven correspondence theorems themselves, in always mode. This PR brings its docstring into literal compliance with the per-library module contract by adding the explicit Covered operations, Covered properties, and Covered edge cases lists, then bumps libraries.yml done_through from 1 to 3, records the status/hex-real-roots-mathlib.scaffolding-reviewed attestation, and leaves lake build HexRealRootsMathlib HexConformance green with check_dag and check_phase4 passing.
🤖 Prepared with Claude Code