This repository was archived by the owner on May 14, 2021. It is now read-only.
Fixed typos#14
Open
v1thesource wants to merge 2 commits intokinecosystem:masterfrom
v1thesource:patch-1
Open
Conversation
Watch out with the naming of installmentsPast. Should really be installmentsPassed. It's confined to the calculateVestedTokens method so there's nothing to worry about if you change it. Will propose the change in a different commit.
For consistency.
Contributor
|
Good catch. Thanks! |
lbeder
approved these changes
Nov 1, 2017
Contributor
|
Thanks @v1thesource ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Watch out with the naming of installmentsPast. Should really be installmentsPassed. It's confined to the calculateVestedTokens method so there's nothing to worry about if you change it. Will propose the change in a different commit.