Skip to content

Housekeeping: Use npm ci when setting up the environment#4190

Merged
Fuzzy3 merged 1 commit intodevelopfrom
housekeeping/revert-to-npm-ci
Dec 9, 2025
Merged

Housekeeping: Use npm ci when setting up the environment#4190
Fuzzy3 merged 1 commit intodevelopfrom
housekeeping/revert-to-npm-ci

Conversation

@Fuzzy3
Copy link
Copy Markdown
Collaborator

@Fuzzy3 Fuzzy3 commented Dec 9, 2025

Which issue does this PR close?

This PR closes no issue

What is the new behavior?

This bug: npm/cli#4828 forced us to move away from using the npm ci command when setting up the environment. However the bug was fixed and released in npm/cli v11.3.0 and thus we can now change the step back to using the npm ci command again.

Does this PR introduce a breaking change?

  • Yes
  • No

Are there any additional context?

Checklist:

The following tasks should be carried out in sequence in order to follow the process of contributing correctly.

Reminders

  • Make sure you have implemented tests following the guidelines in: "The good: Test".
  • Make sure you have updated the cookbook with examples and showcases (for bug fixes, enhancements & new components).

Review

  • Determine if your changes are a fix, feature or breaking-change, and add the matching label to your PR. If it is tooling, dependency updates or similar, add ignore-for-release.
  • Do a self-review.
  • Request that the changes are code-reviewed
  • Request that the changes are UX reviewed (only necessary if your PR introduces visual changes)

When the pull request has been approved it will be merged to develop by Team Kirby.

@Fuzzy3 Fuzzy3 added this to Kirby Dec 9, 2025
@Fuzzy3 Fuzzy3 added housekeeping ignore-for-release Housekeeping, tooling etc. that have no relevance for consumers of Kirby labels Dec 9, 2025
Copy link
Copy Markdown
Collaborator

@RasmusKjeldgaard RasmusKjeldgaard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

YES! 👏

@Fuzzy3 Fuzzy3 merged commit 4d4ad5b into develop Dec 9, 2025
12 checks passed
@Fuzzy3 Fuzzy3 deleted the housekeeping/revert-to-npm-ci branch December 9, 2025 09:57
@github-project-automation github-project-automation Bot moved this to ✅ Done in Kirby Dec 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ignore-for-release Housekeeping, tooling etc. that have no relevance for consumers of Kirby

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

2 participants