fix: warn on malformed items JSON instead of silently swallowing it - #7
Open
rajarshi1 wants to merge 1 commit into
Open
fix: warn on malformed items JSON instead of silently swallowing it#7rajarshi1 wants to merge 1 commit into
rajarshi1 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Warn on malformed items JSON
Fixes #4
Problem
<folder-gallery>accepts a declarativeitemsattribute as a JSON string. InconnectedCallback, parsing it was wrapped in a try/catch with an empty catch block:If the JSON is malformed (a typo, a trailing comma, etc.), the element just silently renders an empty gallery with zero indication of why — making it confusing to debug.
Fix
Log a
console.warnwith the parse error instead of swallowing it:Added a test in
tests/element.test.jsasserting the warning fires exactly once with a message matching/malformed items attribute/, usingvi.spyOn(console, 'warn').Testing
npm test— 41/41 passing (up from 40, new test included)npm run check— cleannpm run build— clean (ESM + CJS)Files changed
src/folder-gallery-element.jstests/element.test.js