Skip to content

[FEATURE] Split collection view onto two parts - overview and documents list - #2039

Merged
sebastian-meyer merged 8 commits into
kitodo:mainfrom
beatrycze-volk:collection-plugin
Jun 29, 2026
Merged

[FEATURE] Split collection view onto two parts - overview and documents list#2039
sebastian-meyer merged 8 commits into
kitodo:mainfrom
beatrycze-volk:collection-plugin

Conversation

@beatrycze-volk

Copy link
Copy Markdown
Collaborator

No description provided.

Extracts the display of the collection label, thumbnail, and description
from `Collection/Show.html` into a new reusable partial
`Collection/Overview.html`. This improves modularity and reduces
duplication, allowing for easier reuse of these common collection
elements.
Introduces new FlexForm settings (`showOverview` and `showDocuments`) for the collection plugin. These checkboxes allow editors to independently control the visibility of the collection overview and its associated documents within the single collection view.

The label for the existing `showSingle` setting has also been refined for better clarity.
@beatrycze-volk beatrycze-volk self-assigned this Jun 29, 2026
@beatrycze-volk beatrycze-volk added ↷ feature A new feature or enhancement. 🗎 documentation An update on documentation. php labels Jun 29, 2026
@beatrycze-volk
beatrycze-volk marked this pull request as draft June 29, 2026 09:54
The `showOverview` and `showDocuments` settings now independently control the visibility of the collection overview and the associated list of documents within the single collection view.

The logic for displaying documents has been extracted into a new private method `showDocuments` to support this conditional rendering and improve code organization.
Enables the `showSingle`, `showOverview`, and `showDocuments` settings in the `CollectionControllerTest` configuration. This ensures the functional test covers scenarios where the recently introduced granular display options for the collection plugin are active, verifying their correct behavior.
@beatrycze-volk
beatrycze-volk marked this pull request as ready for review June 29, 2026 10:10
@codecov

codecov Bot commented Jun 29, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 0.00%. Comparing base (5a1eee5) to head (4af8a9f).

Additional details and impacted files
@@     Coverage Diff      @@
##   main   #2039   +/-   ##
============================
============================

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sebastian-meyer

sebastian-meyer commented Jun 29, 2026

Copy link
Copy Markdown
Member

Updating this branch to latest main unfortunately broke something... (the changes from #2035 seem to be the issue here, because this still uses viewData).

@sebastian-meyer
sebastian-meyer merged commit d939ef5 into kitodo:main Jun 29, 2026
12 checks passed
@beatrycze-volk
beatrycze-volk deleted the collection-plugin branch June 30, 2026 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🗎 documentation An update on documentation. ↷ feature A new feature or enhancement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants