[FEATURE] Client-side paging by beatrycze-volk · Pull Request #878 · kitodo/kitodo-presentation

beatrycze-volk · 2022-12-07T11:47:34Z

Changes are tested - paging works.

Known problems:

there are still some TODOs to be resolved
- check multiple instances of metadata plugin
- initiate load of full texts for empty document controller (resolved in [FEATURE] Remove client-side paging redundancies #938)
- avoid redundancy to DocumentController in PageViewController (resolved in [FEATURE] Remove client-side paging redundancies #938)
- avoid instantiating dlfToolbox multiple times (resolved in [FEATURE] Remove client-side paging redundancies #938)
- consider passing full new state in stateChanged event, then reduce usage of currentPageNo and simultaneousPages properties in Controller.js (removed in [FEATURE] Remove TODO for passing state #946)
- add toplevel sections in TableOfContents.js
- TOC from DB in TableOfContents.js
- check children depth in TableOfContents.js (really needed?)

beatrycze-volk · 2022-12-07T12:08:11Z

+
+<script>
+    window.addEventListener('tx-dlf-documentLoaded', (e) => {
+        // TODO(client-side): When there are multiple instances of metadata plugin?


This part should be tested and checked if the metadata is correctly displayed.

beatrycze-volk · 2022-12-07T12:17:42Z

-    var cnt = Math.min(this.fulltexts.length, this.images.length);
+dlfViewer.prototype.initLoadFulltexts = function (visiblePages) {
+    if (this.docController === null) {
+        // TODO(client-side): Make it work then docController === null


Probably it should be: Make it work when docController === null

beatrycze-volk · 2023-03-29T12:14:03Z

All warnings "..." is defined but never used. are false positives. Those classes are called from fluid templates.

On large documents, rendering metadata of all sections can take a considerable amount of time. Instead, allow to just render the current metadata, and fetch the additional metadata in an API call.

- remove dead variables - fix check for mime type

- removed unused e param from onStateChanged - make fetchMetadata async so no spinner is needed

- remove unused paramaters - decrease complexity of updateNavigationControls

Error: `Inventory link with key "t3tsref:data-type-page-id" (data-type-page-id) not found.`

codecov · 2026-06-23T15:11:43Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 0.00%. Comparing base (7725468) to head (803717c).
⚠️ Report is 17 commits behind head on 6.x.

Additional details and impacted files

@@    Coverage Diff     @@
##   6.x   #878   +/-   ##
==========================
==========================

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

beatrycze-volk marked this pull request as draft December 7, 2022 11:47

beatrycze-volk commented Dec 7, 2022

View reviewed changes

sebastian-meyer added ↝ prototype A provisional pull request still work in progress. ↷ feature A new feature or enhancement. labels Jan 4, 2023

beatrycze-volk force-pushed the sprint-rebased branch from b1bd553 to 12f215c Compare January 20, 2023 09:52

beatrycze-volk force-pushed the sprint-rebased branch from 12f215c to 08c9b78 Compare January 30, 2023 13:00

github-advanced-security AI found potential problems Jan 30, 2023

View reviewed changes

sebastian-meyer changed the title ~~Client sided paging~~ [FEATURE] Client-side paging Jan 30, 2023

beatrycze-volk force-pushed the sprint-rebased branch 4 times, most recently from 7d9cbf1 to 4d07ae1 Compare February 3, 2023 16:47

beatrycze-volk mentioned this pull request Feb 3, 2023

[MAINTENANCE] Simplify and unify check for doc existence #899

Merged

sebastian-meyer mentioned this pull request Feb 6, 2023

Migrate frontend plugins to a client-side application #780

Open

beatrycze-volk force-pushed the sprint-rebased branch 2 times, most recently from 7507d50 to 14853a2 Compare February 6, 2023 17:48

sebastian-meyer added this to the Kitodo.Presentation 5.0.0 milestone Feb 7, 2023

beatrycze-volk force-pushed the sprint-rebased branch from b274075 to b5bf409 Compare February 7, 2023 16:04

github-advanced-security AI found potential problems Feb 7, 2023

View reviewed changes

Comment thread Resources/Public/JavaScript/PageView/PageView.js Fixed

Comment thread Resources/Public/JavaScript/PageView/Navigation.js Fixed

beatrycze-volk force-pushed the sprint-rebased branch 2 times, most recently from 03957df to c794dec Compare February 16, 2023 12:37

beatrycze-volk force-pushed the sprint-rebased branch from c794dec to 64c6835 Compare February 27, 2023 13:07

beatrycze-volk force-pushed the sprint-rebased branch 3 times, most recently from bbadfff to 0a03d63 Compare March 10, 2023 13:15

beatrycze-volk force-pushed the sprint-rebased branch 2 times, most recently from bcce7c6 to a135764 Compare March 28, 2023 08:43

beatrycze-volk mentioned this pull request Mar 29, 2023

Client-side paging slub/dfg-viewer#222

Open

Kajetan Dvoracek and others added 29 commits October 13, 2025 15:42

Refactor: Extract dlfController::eventTarget

cd2c260

Refactor: Don't dispatch stateChanged manually

4aa3cc2

Refactor: Dissolve global tx_dlf_loaded

1a662e1

[EXT] Memoize MetsDocument::getStructureDepth()

26dbe0c

Fetch prerendererd metadata dynamically

b9d78eb

On large documents, rendering metadata of all sections can take a considerable amount of time. Instead, allow to just render the current metadata, and fetch the additional metadata in an API call.

Convert TODO to TODO(client-side)

a38e921

Update and extend documentation

28a78a1

Extend documentation

6aa38b5

Add and update notes about URL generation

4f4c2fd

Fix Codacy warnings

949b89d

Fix toArray method in Doc class

f5724d1

- remove dead variables - fix check for mime type

Adjust DocumentController

9cb28be

Move nonProxyMimeTypes to config

9142202

Implement getAllFiles for IIIFManifest

db15094

Remove unused manifest variable

3718ad9

Fix intend in css

860cc21

Improve Metadata script

5a9a1c4

- removed unused e param from onStateChanged - make fetchMetadata async so no spinner is needed

Improve Navigation script

2570550

- remove unused paramaters - decrease complexity of updateNavigationControls

Assign fulltextEntry directly

be7d6a1

Fix comment

5a42f7b

Allow console logs

ab80f63

Activate full text highlight if full text is active

9e9a5fc

Fix errors marked by PHPStan

efce0a0

Fix Codacy errors

511b5d2

Fix error: Direct use of $GLOBALS Superglobal detected

fd124b2

Fix documentation build

9851461

Error: `Inventory link with key "t3tsref:data-type-page-id" (data-type-page-id) not found.`

Fix PHPStan warnings

e1435bf

Fix return for getStructureDepth() function

db4acb1

Fix Codacy warnings

803717c

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[FEATURE] Client-side paging#878

[FEATURE] Client-side paging#878
beatrycze-volk wants to merge 74 commits into
kitodo:6.xfrom
beatrycze-volk:sprint-rebased

beatrycze-volk commented Dec 7, 2022 •

edited

Loading

Uh oh!

beatrycze-volk Dec 7, 2022

Uh oh!

beatrycze-volk Dec 7, 2022

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

beatrycze-volk commented Mar 29, 2023

Uh oh!

codecov Bot commented Jun 23, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

beatrycze-volk commented Dec 7, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

beatrycze-volk Dec 7, 2022

Choose a reason for hiding this comment

Uh oh!

beatrycze-volk Dec 7, 2022

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

beatrycze-volk commented Mar 29, 2023

Uh oh!

codecov Bot commented Jun 23, 2026

Codecov Report

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

beatrycze-volk commented Dec 7, 2022 •

edited

Loading