fix: exclude spec files from codeToTestRatio code glob#843
Merged
Conversation
The `code` glob `src/**/*.ts` matched spec files (`*.spec.ts`), causing them to appear in both the code and test sets. This inflated the code line count and made the ratio lower than the actual production-to-test ratio. Add `!src/**/*.spec.ts` to exclude spec files from the code side, matching the pattern used in octocov's own config for Go test files.
🎉 Happy commit!
|
Code Metrics Report
Details | | main (d6def62) | #843 (b8c6401) | +/- |
|---------------------|----------------|----------------|------|
| Coverage | 99.2% | 99.2% | 0.0% |
| Files | 5 | 5 | 0 |
| Lines | 134 | 134 | 0 |
| Covered | 133 | 133 | 0 |
+ | Code to Test Ratio | 1:0.5 | 1:1.3 | +0.7 |
| Code | 1678 | 723 | -955 |
| Test | 955 | 955 | 0 |
| Test Execution Time | 2s | 2s | 0s |Reported by octocov |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
codeToTestRatio.codeglobsrc/**/*.tsmatched spec files(
*.spec.ts), causing them to be counted in both the code and test sets.This inflated the denominator (code line count) and produced a lower
ratio than the actual production-to-test ratio.
Add
!src/**/*.spec.tsas an exclusion pattern so the code side countsonly production TypeScript files. The test side is unchanged.
This follows the same pattern used in octocov's own configuration for
excluding Go test files from the code set.