Skip to content

Clarify repository search pagination limits#853

Merged
kitsuyui merged 3 commits into
mainfrom
fix/pagination-limit-constants
Jul 5, 2026
Merged

Clarify repository search pagination limits#853
kitsuyui merged 3 commits into
mainfrom
fix/pagination-limit-constants

Conversation

@kitsuyui

Copy link
Copy Markdown
Owner

Summary

  • Name the GitHub repository search per-page size separately from the local page-count guard.
  • Rename the loop counter so the guard is clearly counted in pages.
  • Preserve the existing pagination guard behavior while replacing anonymous 100 literals with named units.

Verification

  • cargo fmt --all -- --check
  • cargo check
  • cargo test
  • cargo clippy -- -D warnings
  • cargo build
  • git diff --check
  • collateral check: clean
  • implement-validator: overall pass

kitsuyui and others added 3 commits June 25, 2026 07:57
Name the GitHub repository search page size and local page cap separately

so the two `100` values are no longer unit-ambiguous.
@github-actions

github-actions Bot commented Jul 5, 2026

Copy link
Copy Markdown

Code Metrics Report

main (c2444fa) #853 (8176f05) +/-
Coverage 74.3% 74.3% 0.0%
Code to Test Ratio 1:0.0 1:0.0 -0.1
Test Execution Time 42s 5m21s +4m39s
Details
  |                     | main (c2444fa) | #853 (8176f05) |  +/-   |
  |---------------------|----------------|----------------|--------|
  | Coverage            |          74.3% |          74.3% |   0.0% |
  |   Files             |             18 |             18 |      0 |
  |   Lines             |           2010 |           2010 |      0 |
  |   Covered           |           1495 |           1495 |      0 |
- | Code to Test Ratio  |          1:0.0 |          1:0.0 |   -0.1 |
  |   Code              |           2606 |           2608 |     +2 |
  |   Test              |             20 |             20 |      0 |
- | Test Execution Time |            42s |          5m21s | +4m39s |

Code coverage of files in pull request scope (0.0% → 0.0%)

Files Coverage +/- Status
src/github/api.rs 0.0% 0.0% modified

Reported by octocov

@kitsuyui
kitsuyui merged commit b6202d9 into main Jul 5, 2026
17 checks passed
@kitsuyui
kitsuyui deleted the fix/pagination-limit-constants branch July 5, 2026 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant