Skip to content

fix: pass CLI timeout through to renderer#1656

Merged
kitsuyui merged 1 commit into
mainfrom
fix/cli-timeout-propagation
Jul 17, 2026
Merged

fix: pass CLI timeout through to renderer#1656
kitsuyui merged 1 commit into
mainfrom
fix/cli-timeout-propagation

Conversation

@kitsuyui

Copy link
Copy Markdown
Owner

Summary

  • pass the CLI request timeout through to the renderer so programmatic calls honor navigation limits
  • add a focused CLI unit test that verifies timeout propagation without relying on browser timing

Validation

  • bun run lint
  • bun run typecheck
  • bun run test

The CLI request already accepts timeout, but renderToStream dropped it before calling the renderer. Propagate the value and cover the handoff with a focused unit test so CLI timeout flags affect navigation as intended.
@github-actions

Copy link
Copy Markdown

🎉 Happy commit!

  • Commit 8ff02b6661507ed743bf7cf8e8d585ae3aee8705 is unlucky... It contains 666!.

@github-actions

Copy link
Copy Markdown

gh-counter

PR gate

Removed Added +/-
TODO/expect-error 0 0 0

Repo dashboard

main (de60997) #1656 (009ac70) +/-
TODO/expect-error 4 4 0

Reported by gh-counter

@github-actions

Copy link
Copy Markdown

Code Metrics Report

main (de60997) #1656 (009ac70) +/-
Coverage 84.1% 84.1% 0.0%
Code to Test Ratio 1:0.5 1:0.5 +0.0
Test Execution Time 11s 11s 0s
Details
  |                     | main (de60997) | #1656 (009ac70) | +/-  |
  |---------------------|----------------|-----------------|------|
  | Coverage            |          84.1% |           84.1% | 0.0% |
  |   Files             |             11 |              11 |    0 |
  |   Lines             |            234 |             234 |    0 |
  |   Covered           |            197 |             197 |    0 |
+ | Code to Test Ratio  |          1:0.5 |           1:0.5 | +0.0 |
  |   Code              |           1775 |            1834 |  +59 |
+ |   Test              |           1003 |            1061 |  +58 |
  | Test Execution Time |            11s |             11s |   0s |

Code coverage of files in pull request scope (83.3% → 83.3%)

Files Coverage +/- Status
src/cli/index.ts 83.3% 0.0% modified

Reported by octocov

@kitsuyui
kitsuyui merged commit 45132b5 into main Jul 17, 2026
10 checks passed
@kitsuyui
kitsuyui deleted the fix/cli-timeout-propagation branch July 17, 2026 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant