fix: reject repeated x-rendering-proxy headers#1658
Open
kitsuyui wants to merge 1 commit into
Open
Conversation
Code Metrics Report
Details | | main (6aabcd3) | #1658 (c3767e7) | +/- |
|---------------------|----------------|-----------------|-------|
+ | Coverage | 84.3% | 84.4% | +0.1% |
| Files | 11 | 11 | 0 |
| Lines | 243 | 245 | +2 |
+ | Covered | 205 | 207 | +2 |
- | Code to Test Ratio | 1:0.5 | 1:0.5 | -0.1 |
| Code | 1886 | 1905 | +19 |
+ | Test | 1072 | 1080 | +8 |
+ | Test Execution Time | 11s | 8s | -3s |Code coverage of files in pull request scope (95.6% → 96.0%)
Reported by octocov |
Align the server behavior with the documented single-header protocol so duplicate header inputs fail deterministically instead of being concatenated implicitly.
kitsuyui
force-pushed
the
fix/audit-implicit-behavior-audit-002
branch
from
July 17, 2026 14:42
d844beb to
9ee5407
Compare
gh-counterPR gate
Repo dashboard
Reported by gh-counter |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
X-Rendering-Proxyrequest header values instead of concatenating them implicitlyX-Rendering-ProxyWhy
The protocol documentation already describes
X-Rendering-Proxyas a single JSON object. Rejecting repeated header values makes the server behavior deterministic and avoids relying on implicit string concatenation for duplicate headers.Validation
bun run lintbun run typecheckbun run test