Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/server/request_options.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -116,12 +116,12 @@ describe('parseRenderingProxyHeader', () => {
})
})

it('truncates evaluates to at most 10 entries', async () => {
it('keeps all evaluate entries without truncation', async () => {
const scripts = Array.from({ length: 20 }, (_, i) => `script${i}`)
const result = parseRenderingProxyHeader(
JSON.stringify({ evaluates: scripts }),
)
expect(result.evaluates).toHaveLength(10)
expect(result.evaluates).toStrictEqual(scripts.slice(0, 10))
expect(result.evaluates).toHaveLength(20)
expect(result.evaluates).toStrictEqual(scripts)
})
})
4 changes: 1 addition & 3 deletions src/server/request_options.ts
Original file line number Diff line number Diff line change
Expand Up @@ -36,16 +36,14 @@ function normalizeWaitUntil(value: unknown): LifecycleEvent {
return 'load'
}

const MAX_EVALUATES = 10

function normalizeEvaluates(value: unknown): string[] {
if (
!Array.isArray(value) ||
!value.every((item) => typeof item === 'string')
) {
return []
}
return value.slice(0, MAX_EVALUATES)
return value
}

function normalizeTimeout(value: unknown): number | undefined {
Expand Down
Loading