fix: request usage for NVIDIA streams - #658
Open
cruush23 wants to merge 1 commit into
Open
Conversation
Author
|
Hi @kittors, the fork workflows are currently waiting for maintainer approval ( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
stream_options.include_usage=trueonly when the translated upstream payload hasstream=trueProblem
NVIDIA streaming responses return
usage: nullunlessstream_options.include_usageis requested, so CliRelay records zero input/output tokens even though the stream succeeds.A payload rule is not a safe workaround because payload rules match model/protocol but not the
streamflag. The same rule is then applied to non-stream requests, which NVIDIA rejects with:Implementation
The OpenAI compatibility executor now recognizes the official
integrate.api.nvidia.comendpoint and addsstream_options.include_usage=trueinExecuteStreamonly when the final translated payload is actually streaming.Verification
stream_optionsgo test ./internal/runtime/executor -run 'TestOpenAICompatExecutor(RequestsUsageForNVIDIAStreamsOnly|DoesNotRequestUsageForNVIDIANonStream)$' -count=1go test ./...go vet ./...golangci-lint run --config .golangci.ymlgo build ./cmd/server