feat(cate): additional unit tests for multiple treatment levels#156
Draft
feat(cate): additional unit tests for multiple treatment levels#156
Conversation
…evels that are integers
benesom
commented
Mar 19, 2026
| d_int$a <- as.integer(d$a) - 1 | ||
| est_int <- cate(y ~ a * x, a ~ 1, data = d_int) | ||
|
|
||
| expect_equivalent(est_int$estimate$coefmat, est_factor$estimate$coefmat) |
Collaborator
Author
There was a problem hiding this comment.
@kkholst, we should discuss how we want to handle this case where a user provides a treatment variable with more than 2 levels that are encoded as integers. The behavior of cate is currently inconsistent. We get the same estimates for 2 treatment levels that are either encoded as a factor or integer, but estimates differ for 3 treatment levels (see failing test)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.