Skip to content

fix(KLEF): Pnpm 11 build script compat - #4

Merged
isaacwallace123 merged 1 commit into
mainfrom
fix/pnpm-build-compat
May 28, 2026
Merged

fix(KLEF): Pnpm 11 build script compat#4
isaacwallace123 merged 1 commit into
mainfrom
fix/pnpm-build-compat

Conversation

@JeremyNRoos

Copy link
Copy Markdown
Contributor

Pull Request

Summary

  • Fixes the plugin Docker build failing under pnpm 11, which now blocks all lifecycle scripts by default
  • Switches to pnpm install --ignore-scripts && pnpm rebuild esbuild so esbuild's native binary is compiled without opening the door to arbitrary install-time scripts from other packages
  • Adds pnpm.onlyBuiltDependencies to package.json to explicitly allowlist esbuild and sharp going forward

Related Issues

Closes #


Changes

What's Included

  • DockerfileRUN pnpm install replaced with RUN pnpm install --ignore-scripts && pnpm rebuild esbuild
  • package.jsonpnpm.onlyBuiltDependencies: ["esbuild", "sharp"] added under pnpm config key

What's Not Included

  • No changes to plugin logic, components, or API surface
  • No changes to other plugin repos (keycloak, authentik) — they do not use esbuild

Testing

How Was This Tested?

  • docker build of the plugin image completes successfully with pnpm 11
  • Plugin starts, registers with the platform, and serves components correctly after build
  • make dev full stack verified with rebuilt image

Test Coverage

  • Unit tests added or updated
  • Integration tests added or updated
  • Manually tested end-to-end

Breaking Changes

Does this PR introduce breaking changes?

  • Yes
  • No

If yes, describe the impact and any required migration steps:


Security Considerations

  • This PR affects authentication or authorization logic
  • This PR touches secrets, tokens, or environment variables
  • This PR affects infrastructure, deployment pipelines, or network configuration

If any box is checked, describe the security impact and any mitigations applied:


Documentation

Does this PR require documentation updates?

  • Yes
  • No

If yes, check all that apply:

  • README.md
  • ARCHITECTURE.md
  • API reference
  • Architecture diagrams (C4 / DDD)
  • /docs

UI/UX (If Applicable)

  • Includes new components or views
  • Changes styles or theme tokens
  • Responsive behavior verified
  • Requires design approval

Screenshots or recordings:


Pre-Merge Checklist

  • PR title follows semantic format (feat:, fix:, chore:, docs:, refactor:, test:)
  • All CI checks passing
  • Code follows project style guidelines
  • No debug logs or commented-out code left in
  • Dependencies reviewed (no unnecessary additions)
  • No sensitive information included

Reviewer Notes

@JeremyNRoos JeremyNRoos self-assigned this May 28, 2026
@JeremyNRoos
JeremyNRoos force-pushed the fix/pnpm-build-compat branch from a28a908 to 75a5bb4 Compare May 28, 2026 08:01
@github-actions github-actions Bot added bugfix Bug fix chore Maintenance/devex labels May 28, 2026
@isaacwallace123
isaacwallace123 merged commit dd82086 into main May 28, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix Bug fix chore Maintenance/devex

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants