fix(KLEF): Pnpm 11 build script compat - #4
Merged
Conversation
…nlyBuiltDependencies
JeremyNRoos
force-pushed
the
fix/pnpm-build-compat
branch
from
May 28, 2026 08:01
a28a908 to
75a5bb4
Compare
isaacwallace123
approved these changes
May 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Summary
pnpm install --ignore-scripts && pnpm rebuild esbuildso esbuild's native binary is compiled without opening the door to arbitrary install-time scripts from other packagespnpm.onlyBuiltDependenciestopackage.jsonto explicitly allowlistesbuildandsharpgoing forwardRelated Issues
Closes #
Changes
What's Included
Dockerfile—RUN pnpm installreplaced withRUN pnpm install --ignore-scripts && pnpm rebuild esbuildpackage.json—pnpm.onlyBuiltDependencies: ["esbuild", "sharp"]added underpnpmconfig keyWhat's Not Included
Testing
How Was This Tested?
docker buildof the plugin image completes successfully with pnpm 11make devfull stack verified with rebuilt imageTest Coverage
Breaking Changes
Does this PR introduce breaking changes?
If yes, describe the impact and any required migration steps:
Security Considerations
If any box is checked, describe the security impact and any mitigations applied:
Documentation
Does this PR require documentation updates?
If yes, check all that apply:
README.mdARCHITECTURE.md/docsUI/UX (If Applicable)
Screenshots or recordings:
Pre-Merge Checklist
feat:,fix:,chore:,docs:,refactor:,test:)Reviewer Notes