Skip to content

feat(KLEF-188): Framework plugin - #2

Merged
NathanRoos merged 2 commits into
mainfrom
feat/KLEF-188-Framework_Plugin
May 5, 2026
Merged

feat(KLEF-188): Framework plugin#2
NathanRoos merged 2 commits into
mainfrom
feat/KLEF-188-Framework_Plugin

Conversation

@NathanRoos

Copy link
Copy Markdown
Contributor

Pull Request

Summary

Monitoring slot types for the JS plugin SDK.

Related Issues

Closes #


Changes

What's Included

  • MonitoringChartsProps type
  • monitoring.charts slot registration types

What's Not Included


Testing

How Was This Tested?

Used by VictoriaMetrics plugin frontend, verified in local dev.

Test Coverage

  • Unit tests added or updated
  • Integration tests added or updated
  • Manually tested end-to-end

Breaking Changes

Does this PR introduce breaking changes?

  • Yes
  • No

If yes, describe the impact and any required migration steps:


Security Considerations

  • This PR affects authentication or authorization logic
  • This PR touches secrets, tokens, or environment variables
  • This PR affects infrastructure, deployment pipelines, or network configuration

If any box is checked, describe the security impact and any mitigations applied:


Documentation

Does this PR require documentation updates?

  • Yes
  • No

If yes, check all that apply:

  • README.md
  • ARCHITECTURE.md
  • API reference
  • Architecture diagrams (C4 / DDD)
  • /docs

UI/UX (If Applicable)

  • Includes new components or views
  • Changes styles or theme tokens
  • Responsive behavior verified
  • Requires design approval

Screenshots or recordings:


Pre-Merge Checklist

  • PR title follows semantic format (feat:, fix:, chore:, docs:, refactor:, test:)
  • All CI checks passing
  • Code follows project style guidelines
  • No debug logs or commented-out code left in
  • Dependencies reviewed (no unnecessary additions)
  • No sensitive information included

Reviewer Notes

@NathanRoos NathanRoos self-assigned this May 5, 2026
@github-actions github-actions Bot added the feature New feature label May 5, 2026
@NathanRoos
NathanRoos merged commit ce3d9cc into main May 5, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature New feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants