fix: replace deprecated datetime.utcnow() with timezone-aware equivalent#241
Open
Aiudadadadf wants to merge 1 commit intoklen:masterfrom
Open
fix: replace deprecated datetime.utcnow() with timezone-aware equivalent#241Aiudadadadf wants to merge 1 commit intoklen:masterfrom
Aiudadadadf wants to merge 1 commit intoklen:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MigrateHistory.migrated_atusesdt.datetime.utcnowas its default callable.datetime.datetime.utcnow()was deprecated in Python 3.12 and emits aDeprecationWarningon every call. Projects that run their test suite withfilterwarnings = error- a common hardening step - see test failures whenever any migration is applied, even in otherwise unrelated tests.The root cause is in
peewee_migrate/models.py, line 14:The replacement is
lambda: dt.datetime.now(dt.timezone.utc).replace(tzinfo=None). This produces a naive UTC datetime identical in value to whatutcnow()returned, so existing rows and comparisons are unaffected. Thetzinfois stripped before storing so peewee'sDateTimeFieldbehaviour (which expects naive datetimes by default) is preserved.Reproduction steps on Python 3.12+:
The warning text is:
Verified the fix produces an equivalent naive UTC datetime:
Fixes #240