Skip to content

Fix: conditionally generate user session based on disableUserSession … #781

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jerrypena1 merged 1 commit into from
Mar 13, 2026
Merged

Fix: conditionally generate user session based on disableUserSession … #781

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion packages/klevu-core/src/config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -208,7 +208,9 @@ export class KlevuConfig {
setConsentGiven(userConsent: boolean) {
this.consentGiven = userConsent
if (userConsent) {
KlevuUserSession.getDefault().generateSession()
if (!this.disableUserSession) {
KlevuUserSession.getDefault().generateSession()
}
Comment on lines +211 to +213
KlevuIpResolver.getDefault().generateIPData()
Comment thread
jerrypena1 marked this conversation as resolved.
}

Expand Down
9 changes: 6 additions & 3 deletions packages/klevu-core/src/queries/kmcRecommendation/kmcRecommendation.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,16 +163,19 @@ export async function kmcRecommendation(
? `&gpid=${options.itemGroupId}`
: ""
}
const userSegments = KlevuUserSession.getDefault().getSegments()

const conf = KlevuConfig.getDefault()
// Only fetch user segments if user session is enabled
const userSegments = conf.disableUserSession
? []
: KlevuUserSession.getDefault().getSegments()
advFilterParams +=
userSegments.length > 0
? `${advFilterParams.length > 0 ? "&" : "?"}sids=${userSegments.join(
","
)}`
: ""

const conf = KlevuConfig.getDefault()

kmcConfig = await get<KlevuKMCRecommendations>(
`${conf.recommendationsApiUrl}${conf.apiKey}/settings/${recommendationId}${advFilterParams}`
)
Expand Down
Loading