feat(nuget): transitive dependency resolution + editor-only assemblies - #9
Merged
Merged
Conversation
Add opt-in NuGet transitive dependency resolution and editor-only placement for the nuget package type. - nugetResolveDependencies: walk the .nuspec dependency graph, download each transitive dep, and extract its DLLs into the same folder. Framework matching prefers an exact target, falling back to the nearest-compatible lower netstandard version; versions resolve to the range lower bound; package ids dedupe across diamond graphs. - Skip framework/runtime meta-packages and Unity-provided System.* facades (Memory, Buffers, Runtime.CompilerServices.Unsafe, Numerics.Vectors, Threading.Tasks.Extensions, ValueTuple) to avoid duplicate-assembly conflicts. Meta-packages with no lib assemblies are tolerated; their dependencies are still resolved. - editorOnly: route extracted assemblies to an Editor/ special folder instead of Plugins/, for editor-only libs like Roslyn. New internal/packager/nuspec.go handles .nuspec parsing, framework normalization, version-range and skip-list logic. Adds unit tests plus EditorOnly and ResolveDependencies integration tests. Docs updated in README.md and CLAUDE.md. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Copilot stopped reviewing on behalf of
klumhru due to an error
June 22, 2026 17:20
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds two opt-in capabilities to the
nugetpackage type:nugetResolveDependencies— walks the package's.nuspecdependency graph, downloads each transitive dependency, and extracts its DLLs into the same folder. Framework matching prefers an exact target, falling back to the nearest-compatible lowernetstandardversion; versions resolve to the range lower bound; package ids dedupe across diamond graphs.editorOnly— routes extracted assemblies (and resolved deps) into anEditor/special folder instead ofPlugins/, for editor-only libs like Roslyn.Framework/runtime meta-packages and Unity-provided
System.*facades (System.Memory,System.Buffers,System.Runtime.CompilerServices.Unsafe,System.Numerics.Vectors,System.Threading.Tasks.Extensions,System.ValueTuple) are skipped to avoid duplicate-assembly conflicts. Meta-packages with nolib/assemblies are tolerated — their own dependencies are still resolved.Changes
internal/packager/nuspec.go(new) —.nuspecparsing, framework normalization, version-range parsing, dependency-group selection, skip list.internal/packager/nuget.go— recursiveresolveNuGetDeps, best-frameworklib/selection,Editor/vsPlugins/routing.internal/config/config.go—nugetResolveDependencies+editorOnlyfields.README.md,CLAUDE.md.Testing
TestIntegration_NuGet_ResolveDependencies(Grpc.Core, asserts facades skipped),TestIntegration_NuGet_EditorOnly(Newtonsoft.Json →Editor/).Microsoft.CodeAnalysis.CSharp4.8.0: full Roslyn tree resolved, facades dropped, assemblies placed underEditor/.🤖 Generated with Claude Code