Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/knative-downstream.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -49,11 +49,11 @@ jobs:
run: |
go install github.com/google/go-licenses@latest
- name: Checkout Upstream
uses: actions/checkout@v2
uses: actions/checkout@v6
with:
path: ./src/knative.dev/${{ github.event.repository.name }}
- name: Checkout Downstream
uses: actions/checkout@v2
uses: actions/checkout@v6
with:
repository: ${{ matrix.org }}/${{ matrix.repo }}
path: ./src/knative.dev/${{ matrix.repo }}
Expand Down
2 changes: 1 addition & 1 deletion cmd/appender/main.go
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ Small function that demonstrates two concepts:
1. Deserializing / Serializing data
2. Using direct reply to modify incoming events (decorating in this example)

Incoming data is assumbed to be CloudEventBaseData with two fields
Incoming data is assumed to be CloudEventBaseData with two fields
Sequence int
Message string

Expand Down
4 changes: 2 additions & 2 deletions cmd/event_display/main.go
Original file line number Diff line number Diff line change
Expand Up @@ -101,9 +101,9 @@ func run(ctx context.Context) {

ctx = observability.WithConfig(ctx, cfg)

otelResource, err := resource.Default("hearbeat")
otelResource, err := resource.Default("heartbeat")
if err != nil {
log.Printf("failed to correctly initialize otel resource, resouce may be missing some attributes: %s\n", err.Error())
log.Printf("failed to correctly initialize otel resource, resource may be missing some attributes: %s\n", err.Error())
}

meterProvider, err := metrics.NewMeterProvider(
Expand Down
6 changes: 3 additions & 3 deletions cmd/heartbeats/main.go
Original file line number Diff line number Diff line change
Expand Up @@ -124,7 +124,7 @@ func main() {
overrides := duckv1.CloudEventOverrides{}
err := json.Unmarshal([]byte(env.CEOverrides), &overrides)
if err != nil {
log.Printf("[ERROR] Unparseable CloudEvents overrides %s: %v", env.CEOverrides, err)
log.Printf("[ERROR] Unparsable CloudEvents overrides %s: %v", env.CEOverrides, err)
os.Exit(1)
}
ceOverrides = &overrides
Expand All @@ -146,9 +146,9 @@ func main() {

ctx = observability.WithConfig(ctx, cfg)

otelResource, err := resource.Default("hearbeat")
otelResource, err := resource.Default("heartbeat")
if err != nil {
log.Printf("failed to correctly initialize otel resource, resouce may be missing some attributes: %s\n", err.Error())
log.Printf("failed to correctly initialize otel resource, resource may be missing some attributes: %s\n", err.Error())
}

meterProvider, err := metrics.NewMeterProvider(
Expand Down
2 changes: 1 addition & 1 deletion docs/service-accounts.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

Knative Eventing has many pieces. Many of those pieces run Kubernetes Pods,
meaning they run as Kubernetes ServiceAccounts. This document describes Knative
Eventing's recommended use and re-use of ServiceAccounts.
Eventing's recommended use and reuse of ServiceAccounts.

## General Philosophy

Expand Down
2 changes: 1 addition & 1 deletion pkg/adapter/apiserver/delegate.go
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ func (a *resourceDelegate) handleKubernetesObject(makeEvent makeEventFunc, obj i
return nil
}

// sendCloudEvent sends a cloudevent everytime k8s api event is created, updated or deleted.
// sendCloudEvent sends a cloudevent every time k8s api event is created, updated or deleted.
func (a *resourceDelegate) sendCloudEvent(ctx context.Context, event cloudevents.Event) {
event.SetID(uuid.New().String()) // provide an ID here so we can track it with logging
defer a.logger.Debug("Finished sending cloudevent id: ", event.ID())
Expand Down
2 changes: 1 addition & 1 deletion pkg/apis/duck/v1beta1/delivery_conversion.go
Original file line number Diff line number Diff line change
Expand Up @@ -76,4 +76,4 @@ func (sink *DeliverySpec) ConvertFrom(ctx context.Context, from apis.Convertible
}
}

// DeliveryStatus v1beta1 is not convertable to v1 (Channel ref type vs URL)
// DeliveryStatus v1beta1 is not convertible to v1 (Channel ref type vs URL)
2 changes: 1 addition & 1 deletion pkg/apis/duck/v1beta1/delivery_conversion_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -198,5 +198,5 @@ func TestDeliverySpecConversionV1(t *testing.T) {
}
}

// v1beta1 and v1 DeliveryStatus are not convertable to each other.
// v1beta1 and v1 DeliveryStatus are not convertible to each other.
// (channel ref vs apis.URL)
2 changes: 1 addition & 1 deletion pkg/apis/eventing/v1alpha1/register.go
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ const (
RequestReplyBrokerCACertsStatusAnnotationKey = "knative.dev/brokerCACerts"

// RequestReplyBrokerAudienceStatusAnnotationKey is the RequestReply status
// anotation key used to specify the broker's OIDC audience
// annotation key used to specify the broker's OIDC audience
RequestReplyBrokerAudienceStatusAnnotationKey = "knative.dev/brokerAudience"
)

Expand Down
4 changes: 2 additions & 2 deletions pkg/apis/sinks/register.go
Original file line number Diff line number Diff line change
Expand Up @@ -28,13 +28,13 @@ const (
)

var (
// JobSinkResource respresents a Knative Eventing sink JobSink
// JobSinkResource represents a Knative Eventing sink JobSink
JobSinkResource = schema.GroupResource{
Group: GroupName,
Resource: "jobsinks",
}

// IntegrationSinkResource respresents a Knative Eventing sink IntegrationSink
// IntegrationSinkResource represents a Knative Eventing sink IntegrationSink
IntegrationSinkResource = schema.GroupResource{
Group: GroupName,
Resource: "integrationsinks",
Expand Down
10 changes: 5 additions & 5 deletions pkg/apis/sources/register.go
Original file line number Diff line number Diff line change
Expand Up @@ -35,30 +35,30 @@ const (
)

var (
// ApiServerSourceResource respresents a Knative Eventing Sources ApiServerSource
// ApiServerSourceResource represents a Knative Eventing Sources ApiServerSource
//nolint:staticcheck // Not capitalizing "API"
ApiServerSourceResource = schema.GroupResource{
Group: GroupName,
Resource: "apiserversources",
}
// PingSourceResource respresents a Knative Eventing Sources PingSource
// PingSourceResource represents a Knative Eventing Sources PingSource
PingSourceResource = schema.GroupResource{
Group: GroupName,
Resource: "pingsources",
}
// SinkBindingResource respresents a Knative Eventing Sources SinkBinding
// SinkBindingResource represents a Knative Eventing Sources SinkBinding
SinkBindingResource = schema.GroupResource{
Group: GroupName,
Resource: "sinkbindings",
}

// ContainerSourceResource respresents a Knative Eventing Sources ContainerSource
// ContainerSourceResource represents a Knative Eventing Sources ContainerSource
ContainerSourceResource = schema.GroupResource{
Group: GroupName,
Resource: "containersources",
}

// IntegrationSourceResource respresents a Knative Eventing Sources IntegrationSource
// IntegrationSourceResource represents a Knative Eventing Sources IntegrationSource
IntegrationSourceResource = schema.GroupResource{
Group: GroupName,
Resource: "integrationsources",
Expand Down

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion pkg/eventingtls/eventingtlstesting/utils.go
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ import (
cehttp "github.com/cloudevents/sdk-go/v2/protocol/http"
)

// EventChannelHandler is an http.Handler that covert received requests to cloudevent.Event and then
// EventChannelHandler is an http.Handler that converts received requests to cloudevent.Event and then
// send them to the given channel.
func EventChannelHandler(requestsChan chan<- cloudevents.Event) http.Handler {
return http.HandlerFunc(func(writer http.ResponseWriter, request *http.Request) {
Expand Down
2 changes: 1 addition & 1 deletion pkg/observability/key.go
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ var (
MessagingSystem = attributekey.String("messaging.system")
MessagingOperationName = attributekey.String("messaging.operation.name")
MessagingDestinationName = attributekey.String("messaging.destination.name")
MessagingDestinationTemplate = attributekey.String("messaging.destination.tempate")
MessagingDestinationTemplate = attributekey.String("messaging.destination.template")

// attributes relating to the source
SourceName = attributekey.String("kn.source.name")
Expand Down
4 changes: 2 additions & 2 deletions pkg/reconciler/broker/testdata/config-broker-legacy.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -39,11 +39,11 @@ data:
# This defines the default channel template to use for the broker.
channelTemplateSpec: |
# The api and version of the kind of channel to use inthe broker.
# The api and version of the kind of channel to use in the broker.
# This field required.
apiVersion: messaging.knative.dev/v1
# The api and version of the kind of channel to use inthe broker.
# The api and version of the kind of channel to use in the broker.
# This field required.
kind: InMemoryChannel
Expand Down
4 changes: 2 additions & 2 deletions pkg/reconciler/broker/testdata/config-broker.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -37,11 +37,11 @@ data:
# This defines the default channel template to use for the broker.
channel-template-spec: |
# The api and version of the kind of channel to use inthe broker.
# The api and version of the kind of channel to use in the broker.
# This field required.
apiVersion: messaging.knative.dev/v1
# The api and version of the kind of channel to use inthe broker.
# The api and version of the kind of channel to use in the broker.
# This field required.
kind: InMemoryChannel
Expand Down
Loading
Loading