Skip to content

fix(adapter): start pprof server when profiling is enabled #9008

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
theakshaypant wants to merge 1 commit into
base: main
Choose a base branch
from
+10 −0
Open

fix(adapter): start pprof server when profiling is enabled #9008

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions pkg/adapter/v2/main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ package adapter

import (
"context"
"errors"
"flag"
"fmt"
"log"
Expand Down Expand Up @@ -284,11 +285,20 @@ func MainWithInformers(ctx context.Context, component string, env EnvConfigAcces
}()
}

wg.Add(1)
go func() {
defer wg.Done()
if err := pprof.ListenAndServe(); err != nil && !errors.Is(err, http.ErrServerClosed) {
logger.Warnw("Profiling server shut down", zap.Error(err))
}
}()

// Finally start the adapter (blocking)
if err := adapter.Start(ctx); err != nil {
logger.Fatalw("Start returned an error", zap.Error(err))
}

_ = pprof.Shutdown(context.Background())
wg.Wait()
}

Expand Down
Loading