fix: catch panics in NIF to prevent BEAM crash#10
Closed
brentjanderson wants to merge 1 commit intomainfrom
Closed
fix: catch panics in NIF to prevent BEAM crash#10brentjanderson wants to merge 1 commit intomainfrom
brentjanderson wants to merge 1 commit intomainfrom
Conversation
Wraps the css inlining logic in `std::panic::catch_unwind` so any unexpected Rust panic is converted to a RustlerError instead of aborting the BEAM VM.
Author
|
This doesn't fix it, unfortunately. Closing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Wraps the css inlining logic in
std::panic::catch_unwindso any unexpected Rust panic is converted to a RustlerError instead of aborting the BEAM VM.This solution was derived from a Claude code session, so take it with a hefty grain of salt. I have not personally vetted it, as I'm not a Rust expert. Even so, it seems to compile and the concept makes sense - assuming potential SEGFAULTs here are not due to some other memory allocation issue.