Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Risk MEDIUM: Adds a new documentation page for self-service account deletion with a sidebar navigation update and a minor permissions table change.
Reasons
- A new MDX file (
content/manage-your-account/account-deletion.mdx) is added, which triggers MEDIUM risk per new-page rules. - The sidebar navigation file (
data/sidebars/platformSidebar.ts) is modified to include the new page entry. - No component, layout, library, or style files are touched, so HIGH risk triggers do not apply.
- The diff is small (49 additions, 0 deletions across 3 files) and limited to a single documentation section (
manage-your-account). - No package, build config, or OpenAPI spec changes are present.
Notes
- Verify the new page renders correctly at
/manage-your-account/account-deletionand the sidebar entry appears in the expected position. - Confirm internal links (
/manage-your-account/managing-members,/manage-your-account/data-retention) resolve correctly and do not 404. - Check that the
Calloutcomponent usage matches the expected pattern used elsewhere in the docs.
Sent by Cursor Automation: Docs PR classifier
scotidodson
left a comment
scotidodson
left a comment
There was a problem hiding this comment.
Left a couple questions and one style suggestion for the callout
| title="Note" | ||
| text="Account deletion is permanent and cannot be undone. Make sure you have exported or migrated any data you need before proceeding." |
There was a problem hiding this comment.
| title="Note" | |
| text="Account deletion is permanent and cannot be undone. Make sure you have exported or migrated any data you need before proceeding." | |
| title="Account deletion is permanent and cannot be undone." | |
| text="Make sure you have exported or migrated any data you need before proceeding." |
There was a problem hiding this comment.
I wonder if it's better to have this right above the How to header? I don't have a strong opinion on that, but might be more noticeable there?
| - **API keys.** All API keys will be revoked immediately. Any applications or services using these keys will lose access to Knock. | ||
| - **Account members.** All [account members](/manage-your-account/managing-members) will lose access. They will receive an email informing them that the account has been deleted. | ||
| - **Integrations.** Any active channel integrations (email, push, chat, SMS) will stop working. | ||
|
|
There was a problem hiding this comment.
Is it worth adding historical records / message logs here? I know it's addressed in the section below, so might be overkill.
|
|
||
| 1. Open your account settings in the Knock dashboard. | ||
| 2. Navigate to the **General** section. | ||
| 3. Find the **Delete account** option and follow the prompts to confirm. |
There was a problem hiding this comment.
I'm assuming this is correct -- I couldn't find your control changes. Do you have them staging somewhere?
| title="Note" | ||
| text="Account deletion is permanent and cannot be undone. Make sure you have exported or migrated any data you need before proceeding." |
There was a problem hiding this comment.
| title="Note" | |
| text="Account deletion is permanent and cannot be undone. Make sure you have exported or migrated any data you need before proceeding." | |
| title="Account deletion is permanent and cannot be undone." | |
| text="Make sure you have exported or migrated any data you need before proceeding." |
There was a problem hiding this comment.
I wonder if this would be more noticeable above the How to header? I'm not sure.
| - **Production workflows.** Deactivate or migrate any production workflows that are still sending notifications. Deleting your account will immediately stop all notification delivery. | ||
| - **API keys.** All API keys will be revoked immediately. Any applications or services using these keys will lose access to Knock. | ||
| - **Account members.** All [account members](/manage-your-account/managing-members) will lose access. They will receive an email informing them that the account has been deleted. | ||
| - **Integrations.** Any active channel integrations (email, push, chat, SMS) will stop working. |
There was a problem hiding this comment.
Is it worth adding a note about historical records / logs here? I know we cover that in the section below, so might be overkill.
|
|
||
| For context on how Knock handles data during normal operation, see [data retention](/manage-your-account/data-retention). | ||
|
|
||
| ## What happens to account members |
There was a problem hiding this comment.
Noting that this wraps in the TOC. We could update this and then one above to Data deletion and Account member deletion? Couldn't think of any other good options.
| 2. Navigate to the **General** section. | ||
| 3. Find the **Delete account** option and follow the prompts to confirm. | ||
| 4. Enter your account slug to confirm the deletion. | ||
| 5. Confirm the deletion. Your account and all associated data will be permanently removed after 24 hours. |
There was a problem hiding this comment.
Are we going to show a confirmation modal/message? Wondering what "confirm the deletion" looks like. If there are any errors/issues, will we display a toast message informing them of the error and that the deletion wasn't successful?
3 participants
Description
New lightweight docs page for self-service account deletion.