Skip to content

docs(KNO-8318): fix style guide compliance for iOS and Android push notification pages#1357

Merged
webbjordy merged 1 commit intomainfrom
jordy-kno-8318-docs-fix-formattingstyle-guide-compliance-for-iosandroid
Mar 18, 2026
Merged

docs(KNO-8318): fix style guide compliance for iOS and Android push notification pages#1357
webbjordy merged 1 commit intomainfrom
jordy-kno-8318-docs-fix-formattingstyle-guide-compliance-for-iosandroid

Conversation

@webbjordy
Copy link
Contributor

Summary

Style guide compliance fixes for in-app-ui/ios/sdk/push-notifications and in-app-ui/android/sdk/push-notifications. No content meaning changed.

iOS (push-notifications.mdx)

  • We RecommendWe recommend (sentence case)
  • All step headers converted to sentence case (e.g. Enabling Push Notifications in Your AppEnabling push notifications in your app)
  • Bold list labels changed from colon to period (**Configure APNs in Your App:****Configure APNs in your app.**)
  • allowenable per style guide ("enable", not "allow")
  • Trailing period removed from step 3 header
  • alt="Message Template Settings"alt="Message template settings" (sentence case)
  • Both ## Full Example instances → ## Full example
  • FCM section ### Step 2: Override Push Notification Registration Methods → sentence case

Android (push-notifications.mdx)

  • We RecommendWe recommend (sentence case)
  • ## 5:## 5. (colon → period, consistent with all other numbered steps)
  • Duplicate ## 5. Receive push notifications## 7. Receive push notifications (fixes step numbering bug: was 1, 2, 3, 4, 5, 6, 5, 8)

Closes KNO-8318.

Test plan

  • Verify all headers on docs.knock.app/in-app-ui/ios/sdk/push-notifications display in sentence case
  • Verify all headers on docs.knock.app/in-app-ui/android/sdk/push-notifications display in sentence case and step numbers are sequential (1–8)
  • Confirm no broken anchor links from header renames

🤖 Generated with Claude Code

…otification pages

Apply sentence case to all headers and bold list labels, replace
"allow" with "enable" per style guide, fix colon-after-bold to
period, fix Android step numbering (duplicate step 5 → step 7),
and lowercase alt text. No content meaning changed.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@webbjordy webbjordy requested review from a team, connorlindsey and meryldakin and removed request for a team March 18, 2026 14:20
@linear
Copy link

linear bot commented Mar 18, 2026

@vercel
Copy link

vercel bot commented Mar 18, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
docs Ready Ready Preview, Comment Mar 18, 2026 2:23pm

Request Review

Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Risk LOW: Text-only style guide compliance fixes (sentence case, "allow" → "enable", punctuation) across two MDX push notification pages with no structural or code changes.

Reasons

  • Only 2 .mdx content files modified, both within the same section (content/in-app-ui/)
  • Small, symmetric diff (15 additions / 15 deletions) — classic find-and-replace pattern with no content meaning changes
  • No new pages added, no sidebar or navigation changes
  • No component, layout, library, or configuration files touched
  • Changes are mechanical style guide fixes: sentence case headers, colon-to-period formatting, and a step numbering correction

Notes

  • Verify anchor links still resolve correctly after the header renames (e.g., ## Full Example## Full example, step headers)
  • Confirm the Android step numbering fix (duplicate ## 5.## 7.) produces a correct sequential order (1–8)
  • The author (webbjordy) is not in the repository contributor list or org membership, so this PR is not auto-approved despite being low risk
Open in Web View Automation 

Sent by Cursor Automation: Docs PR classifier

Copy link
Contributor

@connorlindsey connorlindsey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌

@webbjordy webbjordy merged commit 3587ad1 into main Mar 18, 2026
6 checks passed
@webbjordy webbjordy deleted the jordy-kno-8318-docs-fix-formattingstyle-guide-compliance-for-iosandroid branch March 18, 2026 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants