Conversation
…otification pages Apply sentence case to all headers and bold list labels, replace "allow" with "enable" per style guide, fix colon-after-bold to period, fix Android step numbering (duplicate step 5 → step 7), and lowercase alt text. No content meaning changed. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
Risk LOW: Text-only style guide compliance fixes (sentence case, "allow" → "enable", punctuation) across two MDX push notification pages with no structural or code changes.
Reasons
- Only 2
.mdxcontent files modified, both within the same section (content/in-app-ui/) - Small, symmetric diff (15 additions / 15 deletions) — classic find-and-replace pattern with no content meaning changes
- No new pages added, no sidebar or navigation changes
- No component, layout, library, or configuration files touched
- Changes are mechanical style guide fixes: sentence case headers, colon-to-period formatting, and a step numbering correction
Notes
- Verify anchor links still resolve correctly after the header renames (e.g.,
## Full Example→## Full example, step headers) - Confirm the Android step numbering fix (duplicate
## 5.→## 7.) produces a correct sequential order (1–8) - The author (
webbjordy) is not in the repository contributor list or org membership, so this PR is not auto-approved despite being low risk
Sent by Cursor Automation: Docs PR classifier
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Summary
Style guide compliance fixes for
in-app-ui/ios/sdk/push-notificationsandin-app-ui/android/sdk/push-notifications. No content meaning changed.iOS (
push-notifications.mdx)We Recommend→We recommend(sentence case)Enabling Push Notifications in Your App→Enabling push notifications in your app)**Configure APNs in Your App:**→**Configure APNs in your app.**)allow→enableper style guide ("enable", not "allow")alt="Message Template Settings"→alt="Message template settings"(sentence case)## Full Exampleinstances →## Full example### Step 2: Override Push Notification Registration Methods→ sentence caseAndroid (
push-notifications.mdx)We Recommend→We recommend(sentence case)## 5:→## 5.(colon → period, consistent with all other numbered steps)## 5. Receive push notifications→## 7. Receive push notifications(fixes step numbering bug: was 1, 2, 3, 4, 5, 6, 5, 8)Closes KNO-8318.
Test plan
docs.knock.app/in-app-ui/ios/sdk/push-notificationsdisplay in sentence casedocs.knock.app/in-app-ui/android/sdk/push-notificationsdisplay in sentence case and step numbers are sequential (1–8)🤖 Generated with Claude Code