Skip to content

feat(audience): add list, get, and open commands#727

Closed
meryldakin wants to merge 1 commit intomeryldakin/audience-foundationfrom
meryldakin/audience-read-commands
Closed

feat(audience): add list, get, and open commands#727
meryldakin wants to merge 1 commit intomeryldakin/audience-foundationfrom
meryldakin/audience-read-commands

Conversation

@meryldakin
Copy link
Contributor

Summary

  • Add audience list: List all audiences with pagination support
  • Add audience get: Display a single audience by key
  • Add audience open: Open audience in Knock dashboard
  • Full test coverage for all three commands

Stack

This is PR 2 of 4 in the audience resource implementation stack:

  1. Foundation - Types, API methods, resource infrastructure
  2. Read Commands (this PR) - list, get, open commands
  3. Filesystem Commands - pull, push, validate commands + marshal layer
  4. Creation/Deletion - new, archive commands + generator

Depends on: #726

Test Plan

  • Tests included for all commands
  • Linting passes

🤖 Generated with Claude Code

Copy link
Contributor Author

meryldakin commented Mar 9, 2026

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

@meryldakin meryldakin marked this pull request as draft March 9, 2026 14:10
@meryldakin meryldakin force-pushed the meryldakin/audience-read-commands branch from a72033c to f2d954f Compare March 9, 2026 14:13
@meryldakin meryldakin force-pushed the meryldakin/audience-foundation branch from 48211e6 to 1166166 Compare March 9, 2026 14:13
@meryldakin meryldakin marked this pull request as ready for review March 9, 2026 14:13
@meryldakin meryldakin force-pushed the meryldakin/audience-foundation branch from 1166166 to fab8d39 Compare March 9, 2026 14:20
@meryldakin meryldakin force-pushed the meryldakin/audience-read-commands branch from f2d954f to 38cdfb4 Compare March 9, 2026 14:20
Add read-only audience commands:
- audience list: List all audiences with pagination support
- audience get: Display a single audience by key
- audience open: Open audience in Knock dashboard

Includes full test coverage for all three commands.
@meryldakin meryldakin force-pushed the meryldakin/audience-read-commands branch from 38cdfb4 to 765af13 Compare March 9, 2026 14:32
@meryldakin
Copy link
Contributor Author

Superseded by #730 (combined PR)

@meryldakin meryldakin closed this Mar 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant