Fix: Prevent Rate Limit Bypass via Header Spoofing#280
Open
riddhima25bet10005-a11y wants to merge 3 commits into
Open
Fix: Prevent Rate Limit Bypass via Header Spoofing#280riddhima25bet10005-a11y wants to merge 3 commits into
riddhima25bet10005-a11y wants to merge 3 commits into
Conversation
|
@riddhima25bet10005-a11y is attempting to deploy a commit to the Karan Mani Tripathi 's projects Team on Vercel. A member of the Team first needs to authorize it. |
Contributor
Author
|
Hey @knoxiboy |
Contributor
Author
|
@knoxiboy reviewed? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes a security vulnerability in the rate limiter (\middleware.tsx) where the \X-Forwarded-For\ header was blindly trusted as the rate limit key. Since this header is client-controlled, it could be spoofed to bypass rate limits (Issue #270).
The middleware now attempts to use the authenticated \userId\ as the primary rate limit key. For unauthenticated requests, it falls back to
eq.ip\ (which is securely populated by hosting platforms like Vercel and cannot be spoofed by the client), before falling back to the headers.
Fixes #270
Changes Made
eq.ip\ over \X-Forwarded-For\
Checklist