Security: Enforce fail-fast authentication on video generation API#286
Open
Krish-Makadiya wants to merge 1 commit into
Open
Security: Enforce fail-fast authentication on video generation API#286Krish-Makadiya wants to merge 1 commit into
Krish-Makadiya wants to merge 1 commit into
Conversation
|
@Krish-Makadiya is attempting to deploy a commit to the Karan Mani Tripathi 's projects Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses a critical cost-abuse vulnerability in the video generation endpoint (
/api/video/generate).Previously, the
currentUser()authentication check was positioned too late in thePOSThandler, allowing unauthenticated requests to bypass early validation and potentially consume server resources before being rejected.The Clerk authentication check has now been moved to the very top of the
POSThandler. This ensures a fail-fast mechanism where unauthenticated requests are immediately met with a401 Unauthorizedresponse.Impact
Changes Made
currentUser()check to the top of thePOSThandler inapp/api/video/generate/route.tsprior to request parsing and logic execution.Closes #174