Skip to content

fix: validate spork signer before processing #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
thepastaclaw wants to merge 1 commit into from
Closed

fix: validate spork signer before processing #2

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions src/spork.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,11 +141,19 @@ bool CSporkManager::IsSporkValid(const CSporkMessage& spork)

bool CSporkManager::ProcessSpork(const CSporkMessage& spork)
{
if (!IsSporkValid(spork)) {
return false;
}

const auto opt_keyIDSigner = spork.GetSignerKeyID();
if (!opt_keyIDSigner) {
return false;
}
const auto keyIDSigner = *opt_keyIDSigner;

uint256 hash = spork.GetHash();
std::string strLogMsg{strprintf("SPORK -- hash: %s id: %d value: %10d", hash.ToString(), spork.nSporkID,
spork.nValue)};
assert(spork.GetSignerKeyID().has_value());
auto keyIDSigner = spork.GetSignerKeyID().value();

{
LOCK(cs); // make sure to not lock this together with cs_main
Expand Down