fix: disable legacy spork P2P on mainnet#3
Draft
thepastaclaw wants to merge 1 commit intoknst:refactor-spork-net-processing-v2from
Draft
fix: disable legacy spork P2P on mainnet#3thepastaclaw wants to merge 1 commit intoknst:refactor-spork-net-processing-v2from
thepastaclaw wants to merge 1 commit intoknst:refactor-spork-net-processing-v2from
Conversation
Author
|
@coderabbitai review |
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up for dashpay#7303
Summary
Follow-up for review feedback on dashpay#7303.
This disables the legacy P2P spork flow on mainnet now that mainnet sporks
are hardcoded/hardened:
GETSPORKSrequests on mainnetSPORKandGETSPORKSmessages without serving cached stateMSG_SPORKinventory as already-have and skip requesting itMSG_SPORKoverGETDATAValidation
git diff --checksrc/test/test_dash --run_test=spork_tests; skipped because thisworktree does not have a built
src/test/test_dashbinary