fix: correct spork signer guard#4
Closed
thepastaclaw wants to merge 2 commits intoknst:refactor-spork-net-processing-v2from
Closed
fix: correct spork signer guard#4thepastaclaw wants to merge 2 commits intoknst:refactor-spork-net-processing-v2from
thepastaclaw wants to merge 2 commits intoknst:refactor-spork-net-processing-v2from
Conversation
5 tasks
Author
|
@coderabbitai review |
knst
force-pushed
the
refactor-spork-net-processing-v2
branch
from
69f09d1 to
6a4ee52
Compare
Owner
|
fixed in-place by force-push |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the inverted signer guard reported on dashpay#7303.
The current branch returns
falsewhenGetSignerKeyID()succeeds, then calls.value()when it failed. This changes the guard to reject only missing signerIDs before dereferencing the optional.
Validation
git diff --check knst/refactor-spork-net-processing-v2...HEADsrc/spork.cppdiff and surroundingCSporkManager::ProcessSpork()flow
src/test/test_dash --run_test=spork_tests(src/test/test_dashisnot built in this worktree)