qemu-run: print QEMU command before execution#1035
qemu-run: print QEMU command before execution#1035robamu wants to merge 2 commits intoknurling-rs:mainfrom
Conversation
robamu
changed the title
|
|
|
You could put it behind an optional |
|
oh, is it specifying verbose for the snapshot tests as well? |
|
I am confused. why does it still fail? The printout is behind the verbose option now. |
| command.stdout(Stdio::piped()); | ||
|
|
||
| if opts.verbose { | ||
| println!("Running QEMU command: {}", pretty(&command)); |
There was a problem hiding this comment.
Printing it to stderr instead of stdout is one option to fix the snapshot test failure. This way you could also always print it and not just in verbose mode.
| println!("Running QEMU command: {}", pretty(&command)); | |
| eprintln!("Running QEMU command: {}", pretty(&command)); |
There was a problem hiding this comment.
The snapshot tests only care about stdout, not stderr
|
The tests are run with |
But that does not matter since the tests only care about stdout and not stderr |
|
ah okay. just did not find it. maybe removing |
robamu
force-pushed
the
qemu-print-command
branch
from
d3962ae to
02e1a71
Compare
Urhengulas
left a comment
Urhengulas
left a comment
There was a problem hiding this comment.
The changes look good to me, but someone still needs to fix the carg-deny failure and then rebase this PR on top of it.
| ### [qemu-run-next] | ||
|
|
||
| * No changes | ||
| * Specifying the `--verbose` / `-v` option now also prints the actual QEMU command being run. |
There was a problem hiding this comment.
Please link the PR number here like in the section below.
Don't forget to add the actual link to the list at the bottom too 😉
This should be done since #1041 was merged. Just need to rebase. |
4 participants
this prints the full QEMU command before executing it