Middleware to show better 4xx, 5xx responses#62
Open
potomak wants to merge 3 commits intoknutin:request_idfrom
Open
Middleware to show better 4xx, 5xx responses#62potomak wants to merge 3 commits intoknutin:request_idfrom
potomak wants to merge 3 commits intoknutin:request_idfrom
Conversation
Owner
|
I'm a bit reluctant to a catch-all in the middleware, as this makes it tricky to call the handle_event/3 callbacks for request_{exception,error,exit}. An option would be to call it from the middleware explicitly. I will have to think about it for a bit.. :-) |
This is the easiest and maybe the worst solution but it solves the problem
of missing calls to handle_event/3 request_{throw,error,exit}.
Author
|
While you were thinking I've tried to solve the problem in the easiest way 😁 Notes:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.