Skip to content

fix: npmjs authentication #139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
koblas merged 1 commit into from
Oct 15, 2025
Merged

fix: npmjs authentication #139

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions .github/workflows/pull_request.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ jobs:

strategy:
matrix:
node-version: [22.x]
node-version: [lts/*]
Copy link

Copilot AI Oct 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The node-version should be a string value, not an array element. Change to node-version: 'lts/*' to match the setup-node action's expected input format.

Suggested change
node-version: [lts/*]
node-version: 'lts/*'

Copilot uses AI. Check for mistakes.

steps:
- uses: actions/checkout@v4
Expand All @@ -35,5 +35,3 @@ jobs:
- run: npm test
env:
CI: true
# - name: Publish to npm
# uses: pascalgn/npm-publish-action@1.2.0
14 changes: 7 additions & 7 deletions .github/workflows/release.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,5 @@
name: Release

permissions:
id-token: write # Required for OIDC
contents: write

on:
#push:
# branches:
Expand All @@ -22,7 +18,11 @@ jobs:
runs-on: ubuntu-latest
outputs:
version: ${{ steps.version.outputs.test }}

permissions:
contents: write # to be able to publish a GitHub release
issues: write # to be able to comment on released issues
pull-requests: write # to be able to comment on released pull requests
id-token: write # to enable use of OIDC for npm provenance
steps:
- name: Checkout
uses: actions/checkout@v4
Expand All @@ -32,7 +32,7 @@ jobs:
- name: Setup Node.js
uses: actions/setup-node@v4
with:
node-version: 22
node-version: lts/*
- name: Install dependencies
run: npm ci
- name: Install semantic-release extra plugins
Expand All @@ -47,7 +47,7 @@ jobs:
id: release
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
NPM_TOKEN: ${{ secrets.NPM_AUTH_TOKEN }}
# NPM_TOKEN: ${{ secrets.NPM_AUTH_TOKEN }}
Copy link

Copilot AI Oct 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The NPM_TOKEN environment variable is commented out but the workflow still attempts to run npx semantic-release, which likely requires npm authentication for publishing. Either uncomment this line or ensure alternative authentication is configured.

Suggested change
# NPM_TOKEN: ${{ secrets.NPM_AUTH_TOKEN }}
NPM_TOKEN: ${{ secrets.NPM_AUTH_TOKEN }}

Copilot uses AI. Check for mistakes.
run: |
npx semantic-release
echo "version=$(npx semantic-release --version)" >> $GITHUB_OUTPUT
Expand Down
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@
],
"repository": {
"type": "git",
"url": "https://github.com/koblas/stdnum-js.git"
"url": "git+https://github.com/koblas/stdnum-js.git"
},
"license": "MIT",
"devDependencies": {
Expand Down