fix: formatting of 8 digit chilean rut

[koblas]

No description provided.

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request resolves an issue where 8-digit Chilean RUTs were not being formatted correctly. The core change involves adjusting the string splitting logic within the RUT formatting utility to ensure accurate presentation for these shorter numbers. Additionally, development dependencies have been updated to their latest versions, and the TypeScript configuration now includes source map generation.

Highlights

• Chilean RUT Formatting Fix: Corrected the format function in src/cl/rut.ts to properly handle 8-digit Chilean RUTs, ensuring accurate presentation.
• Test Coverage Expansion: Added a new test case in src/cl/rut.spec.ts to validate the correct formatting of 8-digit RUTs.
• Dependency Updates: Upgraded several development dependencies, including @eslint/js, eslint, and typescript-eslint, to their latest versions.
• TypeScript Configuration: Enabled the sourceMap option in tsconfig.json for improved debugging.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request fixes an issue with formatting 8-digit Chilean RUTs by using negative indices for splitting the string, which works for both 8 and 9-digit numbers. The change is accompanied by a new test case for the 8-digit format and updates to development dependencies. My review includes a suggestion to improve the robustness of the format function by adding input validation to prevent potential runtime errors when handling inputs of invalid length.

[gemini-code-assist]

While the change to using negative indices in splitAt correctly handles both 8 and 9-digit RUTs, the format function is not robust against inputs of other lengths. If an input with a length other than 8 or 9 is provided (after cleaning), it can lead to a destructuring error. It would be safer to validate the length and also handle potential errors from clean(), similar to how compact() and validate() are implemented.

Suggested change

	const [value] = clean(input);
	const [a, b, c, d] = strings.splitAt(value, 2, 5, 8);
	const [a, b, c, d] = strings.splitAt(value, -7, -4, -1);
	return `${a}.${b}.${c}-${d}`;
	const [value, err] = clean(input);
	if (err) {
	throw err;
	}
	if (value.length < 8 || value.length > 9) {
	throw new exceptions.InvalidLength();
	}
	const [a, b, c, d] = strings.splitAt(value, -7, -4, -1);
	return `${a}.${b}.${c}-${d}`;