Arrays are now converted to numpy arrays before passing to matplotlib functions as some of them expect numpy arrays, not python lists#19
Open
Rob-Rau wants to merge 5 commits intokoji-kojiro:masterfrom
Conversation
… functions as some of them expect numpy arrays, not python lists
Author
|
@koji-kojiro Any thoughts on this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Matplotlib expects Numpy ranges for some of its plotting routines. Mainly streamplot but I'm sure their are others. This PR explicitly takes incoming arrays and converts them to numpy arrays instead of python lists. This should not be a problem as Numpy is a direct dependency of matplotlib so it will be installed if matplotlib is expected to work.