updates for recent python and matplotlib#9
Open
John-Colvin wants to merge 5 commits intokoji-kojiro:masterfrom
Open
updates for recent python and matplotlib#9John-Colvin wants to merge 5 commits intokoji-kojiro:masterfrom
John-Colvin wants to merge 5 commits intokoji-kojiro:masterfrom
Conversation
Owner
|
Hi, @John-Colvin What's the purpose of using |
John-Colvin
force-pushed
the
updates
branch
7 times, most recently
from
8acba89 to
0044913
Compare
John-Colvin
force-pushed
the
updates
branch
2 times, most recently
from
149650c to
567a1fb
Compare
John-Colvin
force-pushed
the
updates
branch
from
567a1fb to
b98fdf4
Compare
koji-kojiro
reviewed
Oct 6, 2017
| "targetPath": "build", | ||
| "workingDirectory": "build", | ||
| "preBuildCommands": ["python $PACKAGE_DIR/python/prebuild.py $PACKAGE_DIR"] | ||
| "preBuildCommands": ["$MATPLOTLIB_D_PYTHON $PACKAGE_DIR/python/prebuild.py $PACKAGE_DIR"] |
Owner
There was a problem hiding this comment.
I recognize that "preBuildCommands" is executed when users install this library by using dub. Is this wrong? If it's right, we had better not use any environment variables to specify the version of Python.
koji-kojiro
reviewed
Oct 6, 2017
| - python3-matplotlib | ||
|
|
||
| before_install: | ||
| - if [ $TRAVIS_OS_NAME = osx ]; then brew install python$PYTHON_VER; brew install homebrew/science/matplotlib; fi |
Owner
There was a problem hiding this comment.
Travis seems to fail due to this line. It seems better to specify Python's version by using pyenv, but I have no experience on travis with pyenv. Can you solve this?
|
Maybe removing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
MATPLOTLIB_D_PYTHON) instead of whateverpythonhappens to be.lowercasefromstring, so useascii_lowercaseinstead (matplotlib functions are all ascii anyway)deprecated, which is a D keyword. By testing for invalid identifiers and appending an_to them, we avoid this problem and any other similar ones that may come along.