Security enhancement: Run web server with unprivileged user#5
Open
DrMurx wants to merge 4 commits intokonstantinj:masterfrom
Open
Security enhancement: Run web server with unprivileged user#5DrMurx wants to merge 4 commits intokonstantinj:masterfrom
DrMurx wants to merge 4 commits intokonstantinj:masterfrom
Conversation
DrMurx
force-pushed
the
master
branch
6 times, most recently
from
2e752aa to
868f948
Compare
* Fix ownership of application code * Run webserver without root privileges * Don't output any errors to the browser * Use `exec` to ease docker process handling
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Despite the level of isolation Docker provides, it's a bad idea to run a web server as
rootin a container:Bugs in either the PHP builtin web server or the postfixadmin code may allow an intruder to modify container-local files (such as the postfixadmin sources itself) and eventually alter mailbox configurations.
Therefore the exposed web server now runs as user
nobodyon an unprivileged port. Consequently, the owner of the postfixadmin sources is assured to berootduring container build time.