fix: add error checking for unchecked return values#16
Open
korjavin wants to merge 2 commits into
Open
Conversation
- Fix errcheck issues in main code files - Add proper error handling for deferred Close() calls - Use blank identifier pattern for intentionally ignored errors - All tests pass (0.800s) Files affected: - conversation.go: tx.Rollback, stmt.Close, rows.Close - elevenlabs.go: resp.Body.Close - class_scheduler.go: cleanupOldClasses error - main.go: db.Close - services.go: transaction and DB resource handling - stat_handler.go: bot.Send errors - cmd/tool-api/main.go: HTTP response handling - importer/importer.go: file and client close
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix errcheck issues across the codebase by properly handling unchecked return values.
Changes
Error handling fixes:
tx.Rollback(),stmt.Close(),rows.Close()using deferred anonymous functionsresp.Body.Close()cleanupOldClasses()return valuedb.Close()bot.Send()errorsfile.Close()andqdrantClient.Close()Pattern used:
For deferred cleanup calls that can't meaningfully handle errors:
For inline calls where errors are intentionally ignored:
Testing
All tests pass:
go test ./...✓Checklist