⚡ Bolt: Use connection pooling for concurrent Supabase storage uploads#47
⚡ Bolt: Use connection pooling for concurrent Supabase storage uploads#47kourdroid wants to merge 1 commit into
Conversation
Co-authored-by: kourdroid <36898160+kourdroid@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
💡 What: Implemented
__aenter__and__aexit__inSupabaseStorageto support acting as an asynchronous context manager, sharing a singlehttpx.AsyncClientacross sequential/concurrent upload requests. Updated the/ingestroute to wrap storage upload logic inside anasync withblock, and updated relevant test mocks to behave correctly as context managers.🎯 Why: Previously, during PDF splitting in the
/ingestroute, the system instantiated a newSupabaseStorageclient, but the underlying HTTP client (httpx.AsyncClient) was instantiated inside theuploadmethod on every call. This meant that each concurrent upload (even though batched usingasyncio.gather) was opening a brand new TCP connection and performing a full TLS handshake, causing a severe N+1 latency bottleneck.📊 Impact: Reduces storage upload connection overhead from O(N) to O(1) by reusing a single HTTP client connection pool across all uploaded split chunks.
🔬 Measurement: Verify by running
pytest tests/test_api_ingest.pyand reviewing logs for the/ingestendpoint to ensure uploads still succeed but execute significantly faster under load.PR created automatically by Jules for task 3448507274474855146 started by @kourdroid