Skip to content

Do not allow Connections without certificate#1

Open
debarshibasak wants to merge 1 commit intokovalromank:mainfrom
debarshibasak:patch-1
Open

Do not allow Connections without certificate#1
debarshibasak wants to merge 1 commit intokovalromank:mainfrom
debarshibasak:patch-1

Conversation

@debarshibasak
Copy link
Copy Markdown

Allowing connections without a certificate beats the purpose of SSL.

@kovalromank
Copy link
Copy Markdown
Owner

The TLS mode is preferTLS though, so even if allowConnectionsWithoutCertificates is false, clients can still connect without TLS.

Removing allowConnectionsWithoutCertificates would make more sense to me if TLS mode is requireTLS.

Maybe a better approach would be to move the TLS mode and allowConnectionsWithoutCertificates parameters to the start command to make it easier to configure the level of TLS security without creating a new config file?

@debarshibasak
Copy link
Copy Markdown
Author

When you set TLS on the server, you want TLS to be enforced. Therefore, I think the second approach is the preferred method, in my opinion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants