Add unit tests for getShardID#149
Merged
kpango merged 2 commits intobugfix/shard-distribution-biasfrom Feb 25, 2026
Merged
Conversation
…h scenarios Co-authored-by: kpango <9798091+kpango@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] WIP address feedback on shard distribution bias bugfix PR
Add unit tests for getShardID
Feb 25, 2026
kpango
approved these changes
Feb 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
getShardIDhad no test coverage despite containing branching logic across three hash strategies and two key-length modes. This addsgache_test.gocovering all meaningful paths.Tests added
maxKeyLength == 0— full key used; exercises single-byte, ≤32-char (maphash), and >32-char (xxh3) pathsmaxKeyLength == 1— single-byte fast path with exact expected-value assertion (uint64(key[0]) & mask)maxKeyLength2–32 —maphashpath; keys both shorter and longer thanklmaxKeyLength> 32 —xxh3path; keys both shorter and longer thanklmaxKeyLength— verifieseffective_kl = min(len(key), kl)clamping[0, mask]— bounds check across all parameter combinationsklbytes must map to the same shard, confirming truncation is applied before hashing🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.