You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Core idea looks okay to me with one caveat - passing limit=0 would be an explicit choice from the client, not the server, and could be used for denial-of-service attacks against large rebuilders.
Pagination is not just a way of transferring large data sets more efficiently, but also a guard against unconstrained dumps eating up serverside resources. It'd likely be possible to bring a rebuilder to a halt by just firing off a bunch of limit=0 queries, hang up the request, and then let the server churn through massive DB materializations until it gets back to actix and sees the aborted request.
I could see this being doable with either a configuration option that allows for it (letting the rebuilder admin take responsibility for possible DoS attacks) or only allowing limit=0 for authenticated clients.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.