improve logging of config & device_properties#810
Draft
improve logging of config & device_properties#810
Conversation
35f722f to
620c188
Compare
Contributor
Author
|
9bd368c to
bfb5aa0
Compare
Contributor
Author
|
In fact, the 4 commits cannot be reviewed in parallel, they all depend on the previous one. |
674d840 to
4ea3734
Compare
- remove sections in device.{cpp,hpp} that were hard to maintain
- improve printing of relevant device_propeties
- support more data type in config.def for better parsing/printing
to be rebased
run parse_env before parse_config_file to be able to set CLVK_CONFIG_FILE with 'log' set inside it and still have it set before 'init_logging' which happen between 'init_early_config' and 'init_config'. Make sure not to override env value with config file ones
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
refactor device_properties to use config.def as the reference
always print warn/error/fatal, whatever the group
move CLVK_CONFIG_FILE to config
run parse_env before parse_config_file to be able to set
CLVK_CONFIG_FILE with 'log' set inside it and still have it set before
'init_logging' which happens between 'init_early_config' and
'init_config'.
Make sure not to override env value with config file ones