Conversation
Install the library and the headers it depends on. Works with a shared library build (`BUILD_SHARED_LIBS=ON`). In theory it works with a static library build as well, but the installation step would have to include the SPIR-V dependencies as static libraries, which this patch doesn't address. Provided some installation info.
kpet
approved these changes
Mar 26, 2022
Owner
kpet
left a comment
kpet
left a comment
There was a problem hiding this comment.
Great, thanks! The CI didn't trigger (Github has been a bit flaky these past few days) but a local build suggests everything should be fine. I'll modify the CI to also exercise installation.
| Note that a static library build at the moment requires the user | ||
| to manually provide the SPIR-V dependencies as static libraries | ||
| in the target project (where you want to embed spirv2clc). | ||
| * `CMAKE_POSITION_INDEPENDENT_CODE` - Whether to enable `fPIC` or similar flags |
Owner
There was a problem hiding this comment.
I'm going to always enable PIC on the library. This will be required by the layer being introduced by #14. I'll tweak this after merging.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Install the library and the headers it depends on.
Works with a shared library build (
BUILD_SHARED_LIBS=ON).In theory it works with a static library build as well,
but the installation step would have to include the SPIR-V dependencies as static libraries,
which this patch doesn't address.
Provided some installation info.
Example install folder:
I wasn't sure how to get rid of the empty folders, but I figured there's no harm in keeping them.
Also note that this doesn't do a "proper" CMake installation, which would require exporting the targets and creating a config file, but it's the first step to making spirv2clc much easier to set up in external projects.